Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #41 - Do not fail when local header compressed size equals to 0 #76

Closed
wants to merge 1 commit into from
Closed

Closes #41 - Do not fail when local header compressed size equals to 0 #76

wants to merge 1 commit into from

Conversation

bbenoist
Copy link

As extracting some "valid" ZIP files was not possible...

Example ZIP file failing before the fix:
http://www.cmake.org/files/v3.2/cmake-3.2.2-win32-x86.zip

Also related to:

@bbenoist
Closes icsharpcode#41 - Do not fail when local header compressed size…
582cb3f 
… equals to 0

As extracting some "valid" ZIP files was not possible...

Example ZIP file failing before the fix:
http://www.cmake.org/files/v3.2/cmake-3.2.2-win32-x86.zip

Also related to:
* icsharpcode#41
* http://community.sharpdevelop.net/forums/t/12404.aspx
@bbenoist bbenoist mentioned this pull request Apr 27, 2015
Closed
@bbenoist
Copy link
Author

cc @jfreilly

@bbenoist
Copy link
Author

bbenoist commented May 4, 2015

Duplicates #18, I did not see that these changes had been already proposed for merging.
Because the commits does not have the same content and I did not had enough time for improved testing, please consider merging #18 instead of #76.

@McNeight McNeight mentioned this pull request Mar 2, 2016
Merged
@McNeight McNeight self-assigned this Apr 14, 2016
@McNeight
Copy link
Contributor

I need to look at both #18 and #41 and compare with this issue to make sure everything lines up.

-Neil

@McNeight McNeight mentioned this pull request Apr 14, 2016
Closed
@McNeight McNeight added the zip Related to ZIP file format label Apr 15, 2016
@McNeight
Copy link
Contributor

McNeight commented May 9, 2016

PR #18 covered the exact same lines of code as PR #76, but was more complete.

Per originator request, PR #18 was merged instead of this PR.

-Neil

@McNeight McNeight closed this May 9, 2016
@icsharpcode icsharpcode locked and limited conversation to collaborators May 9, 2016
@McNeight McNeight modified the milestone: 1.0 May 17, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@McNeight McNeight

Labels
duplicate zip Related to ZIP file format
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bbenoist @McNeight